fix(pool): forcefully recreate pool if already exists #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
previously approved these changes
Jul 1, 2024
There are (extremely rare) situations when a pool that is under control of the `gproc_pool` server may end up in an inconsistent state. This is possible because `gproc_pool:new/3` involves a sequence of operations against `gproc` state, and this sequence is not atomic. In extreme conditions, one of the operations may fail, kill the `gproc_pool` server and leave the pool state inconsistent. The reasonable (and advertised) way to deal with it is to `force_delete` it first. This should be safe as the assumption is that an `ehttpc_pool` owns its `gproc_pool`.
keynslug
force-pushed
the
fix/EMQX-12421/recreate
branch
from
959ea68 to
c05d57f
Compare
thalesmg
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are (extremely rare) situations when a pool that is under control of the
gproc_poolserver may end up in an inconsistent state. This is possible becausegproc_pool:new/3involves a sequence of operations againstgprocstate, so the whole change is not atomic. In extreme conditions, one of the operations may fail, kill thegproc_poolserver and leave the pool state inconsistent. The reasonable (and advertised) way to deal with it is toforce_delete/1it first. This should be safe as the assumption is that anehttpc_poolowns itsgproc_pool.