fix: async reply for expired requests #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
approved these changes
Jan 13, 2025
src/ehttpc.erl
Outdated
| %% delivered to self()'s mailbox | ||
| %% or the stream process might send more messages | ||
| %% before receiving the cancel message. | ||
| _ = gun:cancel(Client, StreamRef), |
There was a problem hiding this comment.
Q: since we now send just {error, expired} to the callback, without the late response, shouldn't we still cancel the stream?
prior to this fix, callback style async requests are not replied if a request is expired. fixed to always evaluate the callback, but do not send reply for gen_server calls.
zmstone
force-pushed
the
250113-maybe-reply-expired-for-callbacks
branch
from
fa2c4a2 to
909d307
Compare
|
the async callback is actually always evaluated even after the request is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this fix, callback style async requests are not replied if a request is expired.
fixed to always evaluate the callback, but do not send reply for gen_server calls.