Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ehttpc from 0.5.0 to 0.6.0 #13942

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Oct 7, 2024

En enhancement to auto-recover: #12974

Release version: v/e5.8.1

Summary

ehttpc-0.6.0 introduced zombie connection detection.
see emqx/ehttpc#57

by default, if a http connection is inactive for more than 10s after the last sent request has been expired, it will try to reconnect.

Before the connection is force restarted, an error level log with message force_reconnecting_zombie_http_connection is written.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

0.6.0 introudced zombie connection detection
by default, if a http connection is inactive for more than 10s after
the last sent request has been expired, it will try to reconnect
@zmstone zmstone requested a review from a team as a code owner October 7, 2024 11:31
@zmstone zmstone marked this pull request as draft October 7, 2024 11:38
@zmstone zmstone marked this pull request as ready for review October 7, 2024 12:04
@zmstone zmstone merged commit f4c3106 into emqx:release-58 Oct 7, 2024
195 checks passed
@zmstone zmstone deleted the 1007-upgrade-ehttpc-from-0.5.0-to-0.6.0 branch October 7, 2024 14:51
@emqxqa
Copy link

emqxqa commented Oct 8, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants