feat: add option for more graceful request failures #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
approved these changes
Nov 13, 2023
savonarola
force-pushed
the
1113-no-exit
branch
5 times, most recently
from
d5c8817 to
e0e2093
Compare
savonarola
force-pushed
the
1113-no-exit
branch
from
e0e2093 to
e6baa56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc_client:unary(...),grpc_client:send(...),grpc_client:recv(...)exit if the called process exits (likegen_server:call). This is not always required, so we add an option which makes the client raise an error instead of exit.