Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTemplateList.ts): fix that can't import template #595

Merged
merged 1 commit into from
May 14, 2024

Conversation

oucb
Copy link
Member

@oucb oucb commented May 14, 2024

No description provided.

@oucb oucb added the bug Something isn't working label May 14, 2024
@oucb oucb requested a review from ysfscream May 14, 2024 06:48
} finally {
isImportTemplate.value = false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to remove isImportTemplate.value = false if it has always been true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ysfscream need to use it later, after closing the dialog it will be set to false

@ysfscream ysfscream merged commit 5dcd017 into v2.6 May 14, 2024
1 check passed
@ysfscream ysfscream deleted the import-template branch May 14, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants