Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add argument to emrun for file dump_out directory #15801

Merged
merged 12 commits into from
Jan 11, 2022

Conversation

arsnyder16
Copy link
Contributor

add options for dump_out directory

I am not sure where the true emrun is i also made the following PR juj/emrun#17.

Also tweak the following.

  • Unquote the file path passed in the request, this fix cases with spaces in the path
  • Build full directory structure for where the file should be dumped

@arsnyder16 arsnyder16 changed the title add argument for dump_out directory add argument to emrun for file dump_out directory Dec 16, 2021
@sbc100 sbc100 requested a review from juj December 17, 2021 18:31
@sbc100
Copy link
Collaborator

sbc100 commented Dec 17, 2021

Maybe add to something to the emrun test in tests/test_browser.py?

Copy link
Collaborator

@juj juj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@juj
Copy link
Collaborator

juj commented Jan 4, 2022

I am not sure where the true emrun is i also made the following PR juj/emrun#17.

Yeah, I should probably sunset that repo - there are a few people that are still reading from there, but the development has moved to Emscripten repo practically fully.

@kripken
Copy link
Member

kripken commented Jan 5, 2022

The test failures here look random or stale. Please merge in latest main, that should fix them.

@sbc100 sbc100 enabled auto-merge (squash) January 11, 2022 04:03
@sbc100 sbc100 merged commit ac54c94 into emscripten-core:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants