Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting docs/js folder and extra_javascript in mkdocs.yaml #2311

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Deleting docs/js folder and extra_javascript in mkdocs.yaml #2311

merged 5 commits into from
Nov 2, 2023

Conversation

MhmoudGit
Copy link
Contributor

@MhmoudGit MhmoudGit commented Oct 22, 2023

Summary

I found an issue about the chat button not working on website and there was a suggestion to remove the docs/js files.
So I deleted the extra_javascript in mkdocs.yaml and the js folder altogether.

Impact

This will remove the "Open Chat" button from the docs website.

Checklist

  • [+] I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • [+] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [+] I've updated the documentation accordingly.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be deleted, not commented out.

Would you be able to create the same PR on httpx and uvicorn?

@MhmoudGit
Copy link
Contributor Author

MhmoudGit commented Oct 23, 2023

Okay I'll delete it.
yes sure I'll do the same on httpx and uvicorn.

Edit:
I created the same PR on httpx and uvicorn. waiting for review @Kludex

@MhmoudGit MhmoudGit requested a review from Kludex October 23, 2023 13:33
@MhmoudGit MhmoudGit changed the title commenting extra_javascript in mkdocs.yaml Deleting docs/js folder and extra_javascript in mkdocs.yaml Oct 23, 2023
@Kludex Kludex merged commit d3e65c1 into encode:master Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants