refactor(core): extract common logic to base classes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and hubs - Introduced `WartBaseController`, consolidating shared functionality from `WartController` and `WartControllerJwt`. - Simplified both controllers by inheriting from `WartBaseController` to reduce duplication. - Extracted shared logic from `WartHub` and `WartHubJwt` into a new `WartBaseHub`. - Both hubs now inherit from `WartBaseHub`, centralizing SignalR logic. - Updated method signatures and reused existing utilities to enhance maintainability. This refactoring reduces duplication, enhances modularity, and simplifies future maintenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WartBaseController, consolidating shared functionality fromWartControllerandWartControllerJwt.WartBaseControllerto reduce duplication.WartHubandWartHubJwtinto a newWartBaseHub.WartBaseHub, centralizing SignalR logic.