Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request #414

Draft
wants to merge 60 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
60 commits
Select commit Hold shift + click to select a range
e6640c8
Add Windows testing to GitHub Actions
oldgithubman Oct 13, 2024
f384db5
Refactor and improve type annotations in mocks.py
oldgithubman Oct 13, 2024
d981a17
Update AGW package documentation to version 0.9.7
oldgithubman Oct 13, 2024
d141daf
Refactor and enhance AGW artmanager module
oldgithubman Oct 13, 2024
0c917df
Add bold tab selection style and improve type hints
oldgithubman Oct 13, 2024
307a1a2
Update FourWaySplitter for better documentation and Python 3 compatib…
oldgithubman Oct 13, 2024
b4e65a6
Update GradientButton for Python 3 and Phoenix
oldgithubman Oct 13, 2024
90851e5
Update LabelBook and FlatImageBook documentation
oldgithubman Oct 13, 2024
3b94aa2
Update PyGauge to support drawing value or percentage
oldgithubman Oct 13, 2024
c5cfcc8
Refactor and improve audio module documentation
oldgithubman Oct 13, 2024
e382e2c
Refactor and improve code readability in config.py
oldgithubman Oct 14, 2024
3ac2eb6
Update win32com imports to win32comext
oldgithubman Oct 14, 2024
ddc0696
Refactor imports and improve readability
oldgithubman Oct 14, 2024
c6dd4bb
Update flake8 config for stricter checks
oldgithubman Oct 14, 2024
5a39997
Reorganize and update .gitignore file
oldgithubman Oct 14, 2024
bd8ac7a
Update requirements.txt with new dependencies
oldgithubman Oct 14, 2024
3101b65
Add type hints to ArtManager.Initialize
oldgithubman Oct 14, 2024
e614e63
Refactor and document EDID retrieval and parsing
oldgithubman Oct 14, 2024
4d75b98
Refactor and clean up freeze.py script
oldgithubman Oct 14, 2024
83eec46
Refactor imports and Python version check
oldgithubman Oct 14, 2024
cf9dc8c
Fix formatting and minor typos in pnp.ids
oldgithubman Oct 14, 2024
69421d6
Refactor imports and improve readability in profile_loader.py
oldgithubman Oct 14, 2024
77f82ef
Refactor and improve RealDisplaySizeMM.py
oldgithubman Oct 14, 2024
72eeeb7
Refactor and enhance AGW artmanager module
oldgithubman Oct 13, 2024
9648079
Refactor and improve code readability in config.py
oldgithubman Oct 14, 2024
c1de081
Refactor imports and improve readability
oldgithubman Oct 14, 2024
24951ea
Refactor and document EDID retrieval and parsing
oldgithubman Oct 14, 2024
00a5a9a
- [#414] Fixed `DisplayCAL.lib.agw.artmanager` for MacOS (and possibl…
eoyilmaz Oct 14, 2024
e49641e
Refactor taskbar progress using ctypes for ITaskbarList3
oldgithubman Oct 14, 2024
51b663d
- [#414] Trying to fix Windows workflow (1).
eoyilmaz Oct 14, 2024
2d5291b
Format taskbar.py
oldgithubman Oct 14, 2024
2bfb3a4
Refactor and enhance util_os.py for better readability and functionality
oldgithubman Oct 14, 2024
39fdba8
Add docstrings and improve code readability
oldgithubman Oct 14, 2024
52698ac
- [#414] Trying to fix Windows workflow (2).
eoyilmaz Oct 14, 2024
35693df
Reorganize imports and fix indentation
oldgithubman Oct 14, 2024
acb860f
Refactor imports in wxCCXXPlot.py for clarity and consistency
oldgithubman Oct 14, 2024
e546a57
Refactor imports for better readability and organization
oldgithubman Oct 14, 2024
bd55ea5
Refactor imports in wxLUTViewer.py for clarity and organization
oldgithubman Oct 14, 2024
c80a73e
Refactor imports in wxMeasureFrame.py for clarity
oldgithubman Oct 14, 2024
9666556
Reorganize imports for better readability and structure
oldgithubman Oct 15, 2024
a78b04e
Refactor imports in wxScriptingClient.py
oldgithubman Oct 15, 2024
43242b3
Refactor imports in wxSynthICCFrame.py
oldgithubman Oct 15, 2024
7bb3e09
Refactor imports and improve readability
oldgithubman Oct 15, 2024
59b30ad
Refactor imports and improve code readability
oldgithubman Oct 15, 2024
bc4a3dc
Refactor and improve comments in tests/conftest.py
oldgithubman Oct 15, 2024
7e90ba2
Update test_colord.py to use platform module and fix import order
oldgithubman Oct 15, 2024
a945d1e
Update tests and dependencies for Python 3.11
oldgithubman Oct 15, 2024
96ef5af
Add debugging print statements to test_ICCProfile.py
oldgithubman Oct 15, 2024
feda88d
Convert AGW package docstring to use double quotes
oldgithubman Oct 15, 2024
3afeea1
Refactor and update project configuration files
oldgithubman Oct 16, 2024
84f7f94
Delete .flake8 and update .gitignore
oldgithubman Oct 16, 2024
105cd7d
Refactor and improve FourWaySplitter documentation and types
oldgithubman Oct 18, 2024
80a2842
Refactor GradientButton for better type hints and readability
oldgithubman Oct 18, 2024
f00706f
Refactor and improve LabelBook and FlatImageBook
oldgithubman Oct 23, 2024
561e825
[#414] Updated `.github/workflows/pytest.yml` to disable C-Extension …
eoyilmaz Oct 24, 2024
eabc81b
[#414] Removed all the `# noqa: SC100` comments as it is better to ad…
eoyilmaz Oct 24, 2024
23f40ad
[#414] Refactored the `DisplayCAL.lib.agw.artmanager`.
eoyilmaz Oct 24, 2024
b433eba
[#414] Refactored the `DisplayCAL.lib.agw.fmresources`.
eoyilmaz Oct 24, 2024
3f3d66f
[#414] Fixed most of the linting errors in `DisplayCAL.lib.agw.artman…
eoyilmaz Oct 24, 2024
ea2febe
[#414] Introduced some more style changes to `fourwaysplitter` and `g…
eoyilmaz Oct 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .coveragerc
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[run]
omit = ./venv/*,*tests*,*__init__.py,*.pyw
omit = *__init__.py,*.pyw,./venv/*,*tests*
18 changes: 9 additions & 9 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,23 @@
root = true

[*]
indent_style = space
indent_size = 4
trim_trailing_whitespace = true
insert_final_newline = true
charset = utf-8
end_of_line = lf
indent_size = 4
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true

[*.yml]
indent_size = 2
[*.bat]
end_of_line = crlf
indent_style = tab

[*.md]
insert_final_newline = false
trim_trailing_whitespace = false

[*.bat]
indent_style = tab
end_of_line = crlf
[*.yml]
indent_size = 2

[LICENSE]
insert_final_newline = false
Expand Down
5 changes: 0 additions & 5 deletions .flake8

This file was deleted.

83 changes: 79 additions & 4 deletions .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
types: [opened, synchronize, reopened, ready_for_review, unlabeled]
branches:
- develop
push:
branches:
- develop

jobs:
build:
Expand All @@ -13,7 +16,7 @@ jobs:
runs-on: ubuntu-22.04

strategy:
fail-fast: False
fail-fast: false
matrix:
python-version:
- "3.8"
Expand Down Expand Up @@ -92,14 +95,15 @@ jobs:

- name: Install Python dependencies
run: |
pip install -r requirements-tests.txt
pip install -r requirements-dev.txt
pip install -r requirements-tests.txt -r requirements-dev.txt

- name: Build DisplayCAL
run: |
sudo chmod a+rw /etc/udev/rules.d
python3 -m build
pip install dist/DisplayCAL-*.whl
ls -l dist/
wheel_file=$(ls dist/DisplayCAL-*.whl)
pip install $wheel_file

- name: Test with pytest
run: |
Expand All @@ -111,3 +115,74 @@ jobs:
name: code-coverage-report-${{ env.py_version }}-${{ matrix.wx-version }}
path: htmlcov
retention-days: 10

windows:
name: Test with Python ${{ matrix.python-version }} on Windows
runs-on: windows-latest

strategy:
fail-fast: false
matrix:
python-version:
- "3.8"
- "3.9"
- "3.10"
- "3.11"

steps:
- uses: actions/checkout@v4

- name: Set Environment Variables
run: |
$py_version = "${{ matrix.python-version }}" -replace '\.', ''
echo "py_version=$py_version" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
if ("${{ matrix.python-version }}" -eq "3.8") {
echo "add_dir_str=${{ matrix.python-version }}" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
} elseif ("${{ matrix.python-version }}" -eq "3.9") {
echo "add_dir_str=${{ matrix.python-version }}" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
} elseif ("${{ matrix.python-version }}" -eq "3.10") {
echo "add_dir_str=cpython-310" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
} elseif ("${{ matrix.python-version }}" -eq "3.11") {
echo "add_dir_str=cpython-311" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
} elseif ("${{ matrix.python-version }}" -eq "3.12") {
echo "add_dir_str=cpython-312" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
}

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Update pip
run: |
python -m pip install --upgrade pip
pip install wheel

# - name: Install wxPython
# run: |
# pip install -U wxPython

- name: Install Python dependencies
run: |
pip install -r requirements-tests.txt -r requirements-dev.txt

# - name: Compile C-Extensions
# run: |
# python -m build
# ls -l dist/
# $wheel_file = Get-ChildItem -Path dist -Filter DisplayCAL-*.whl
# pip install $wheel_file.FullName
# $PYPATH = Get-Command python | Select-Object -ExpandProperty Source
# $PYDIR = Split-Path $PYPATH
# Copy-Item -Path "$PYDIR\Lib\site-packages\DisplayCAL\lib64\python${{ env.py_version }}\RealDisplaySizeMM.*.pyd" -Destination "./DisplayCAL/lib64/python${{ env.py_version }}/"

- name: Test with pytest
run: |
python -m pytest --verbose -n auto -W ignore --color=yes --cov=. --cov-report html

- name: Archive code coverage results
uses: actions/upload-artifact@v4
with:
name: code-coverage-report-${{ env.py_version }}-windows
path: htmlcov
retention-days: 10
45 changes: 23 additions & 22 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,33 +1,34 @@
__pycache__/
.DS_Store
/.venv/
.vscode/
/DisplayCAL/__version__.py
/build/
/dist/
/venv/
.venv*/
/INSTALLED_FILES
/MANIFEST.in
MANIFEST.in
/VERSION
__pycache__/
.vscode/
*.blend1
*.code-workspace
/.coverage
/.pytest_cache/
/tests/data/icc/Monitor 1 #1 2022-03-09 16-13 D6500 2.2 F-S XYZLUT+MTX.B2A1.post.CLUT.png
/tests/data/icc/Monitor 1 #1 2022-03-09 16-13 D6500 2.2 F-S XYZLUT+MTX.B2A1.post.CLUT.smooth.png
/DisplayCAL.egg-info/top_level.txt
/.venv/
/build/
/DisplayCAL.egg-info/dependency_links.txt
/DisplayCAL.egg-info/PKG-INFO
/DisplayCAL.egg-info/requires.txt
/DisplayCAL.egg-info/SOURCES.txt
/DisplayCAL.egg-info/PKG-INFO
/DisplayCAL.egg-info/dependency_links.txt
*.blend1
/.coverage
/DisplayCAL/ref/*.log
/DisplayCAL.egg-info/top_level.txt
/DisplayCAL/__version__.py
/DisplayCAL/lib64/python310/*.so
/DisplayCAL/lib64/python311/*.pyd
/DisplayCAL/lib64/python38/*.so
/DisplayCAL/lib64/python39/*.so
/DisplayCAL/lib64/python310/*.so
/DisplayCAL/lib64/RealDisplaySizeMM.cpython-310-darwin.so
/DisplayCAL/lib64/RealDisplaySizeMM.cpython-311-darwin.so
/DisplayCAL/lib64/RealDisplaySizeMM.cpython-312-darwin.so
/DisplayCAL/ref/*.log
/dist/
/INSTALLED_FILES
/MANIFEST.in
/tests/data/icc/Monitor 1 #1 2022-03-09 16-13 D6500 2.2 F-S XYZLUT+MTX.B2A1.post.CLUT.png
/tests/data/icc/Monitor 1 #1 2022-03-09 16-13 D6500 2.2 F-S XYZLUT+MTX.B2A1.post.CLUT.smooth.png
/venv/
/VERSION
cacert.pem
*.code-workspace
main.py
main.py
MANIFEST.in
Loading
Loading