Feature/Checkbox rework from CC into FC #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by: track-bundle-size
new sizes (raw)To set the sizes as a new baseline, you can copy/paste next content to the {
"version": "5.7.1",
"timestamp": "2024-04-06",
"sizes": {
"templateApp": {
"css": 280548,
"js": 804679
},
"@epam/app": {
"css": 1587897,
"js": 5005368
},
"@epam/draft-rte": {
"css": 9762,
"js": 45308
},
"@epam/electric": {
"css": 2289,
"js": 2299
},
"@epam/promo": {
"css": 40368,
"js": 16101
},
"@epam/uui-extra": {
"css": 0,
"js": 213
},
"@epam/loveship": {
"css": 49451,
"js": 54140
},
"@epam/uui-components": {
"css": 22214,
"js": 239689
},
"@epam/uui-core": {
"css": 0,
"js": 333823
},
"@epam/uui-db": {
"css": 0,
"js": 43327
},
"@epam/uui-docs": {
"css": 3189,
"js": 201400
},
"@epam/uui-editor": {
"css": 12625,
"js": 164792
},
"@epam/uui-timeline": {
"css": 2251,
"js": 46073
},
"@epam/uui": {
"css": 268310,
"js": 332043
}
}
}Generated by: generate-components-api Total amount of exported types/props without JSDoc comments
|
AlekseyManetov
requested changes
Apr 4, 2024
| @@ -103,4 +120,14 @@ describe('Checkbox', () => { | |||
| expect(onBlur).toHaveBeenCalled(); | |||
| expect(input).not.toHaveFocus(); | |||
| }); | |||
|
|
|||
| it('when state equals isInvalid: true, Checkbox_container must have a \'uui-invalid\' class', async () => { | |||
There was a problem hiding this comment.
Such cases better check via snapshot tests, just render Checkbox with invalid state. I guess we can add this case to the snapshot in UUI.
| it('should be rendered correctly', () => { | ||
| const tree = renderer.create(<Checkbox value={ null } onValueChange={ jest.fn } size="18" mode="cell" />).toJSON(); | ||
| it('should render with maximum props', async () => { | ||
| const tree = await renderSnapshotWithContextAsync(<Checkbox value={ null } onValueChange={ jest.fn } size="18" mode="cell" />); |
There was a problem hiding this comment.
Add wider range of different props to this test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link(if exists):
Description: [Checkbox]: rework from CC into FC