Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VerticalTabButton]: reverted paddings & gaps to the previous state #2593

Conversation

siarhei-epam
Copy link
Collaborator

@siarhei-epam siarhei-epam commented Oct 30, 2024

Issue link(if exists): #2582

Description:

reverted paddings & gaps to previous values for all sizes
changed the order of placing the icon to the left of the text and the count indicator, now the first icon then the count indicator - see merge request #2530

Copy link

github-actions bot commented Oct 30, 2024

Generated by: track-bundle-size
Generated at: Thu, 31 Oct 2024 16:39:27 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.10.0 (2024-10-15)
CI Status: ok

Module Baseline Size
(v5.10.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 760.53 765.02 +4.49
js:+3.88
css:+0.61
🆗 684.48 - 836.59
@epam/app 5578.86 5626.26 +47.39
js:+4.4
css:+42.99
🆗 5020.98 - 6136.75
@epam/draft-rte 53.77 53.77 +0.01
js:+0
css:+0
🆗 48.39 - 59.15
@epam/electric 4.57 4.59 +0.01
js:+0
css:+0.01
🆗 4.12 - 5.03
@epam/promo 57.15 57.35 +0.2
js:0
css:+0.2
🆗 51.44 - 62.87
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 93.74 93.97 +0.23
js:+0.01
css:+0.22
🆗 84.36 - 103.11
@epam/uui-components 263.21 264.13 +0.92
js:+0.92
css:0
🆗 236.89 - 289.54
@epam/uui-core 337.45 337.82 +0.37
js:+0.37
css:0
🆗 303.7 - 371.19
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 207.12 207.12 0
js:0
css:0
🆗 186.41 - 227.83
@epam/uui-editor 183.61 183.71 +0.1
js:+0.08
css:+0.01
🆗 165.25 - 201.97
@epam/uui-timeline 79.51 79.54 +0.03
js:+0.03
css:0
🆗 71.56 - 87.46
@epam/uui 606.81 607.98 +1.17
js:+0.74
css:+0.42
🆗 546.13 - 667.49
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.11.0-rc.0",
  "timestamp": "2024-10-31",
  "sizes": {
    "templateApp": {
      "css": 300668,
      "js": 482715
    },
    "@epam/app": {
      "css": 722992,
      "js": 5038295
    },
    "@epam/draft-rte": {
      "css": 9773,
      "js": 45296
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2409
    },
    "@epam/promo": {
      "css": 47830,
      "js": 10894
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53666,
      "js": 42553
    },
    "@epam/uui-components": {
      "css": 22527,
      "js": 247943
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 345926
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2448,
      "js": 209640
    },
    "@epam/uui-editor": {
      "css": 12748,
      "js": 175370
    },
    "@epam/uui-timeline": {
      "css": 2254,
      "js": 79194
    },
    "@epam/uui": {
      "css": 278211,
      "js": 344356
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 300 (+0) 🆗
Props 233 (+0) 🆗

@siarhei-epam siarhei-epam self-assigned this Oct 31, 2024
@siarhei-epam siarhei-epam changed the title 2582 vertical tab button get back paddings as per previous component version [VerticalTabButton]: reverted paddings & gaps to the previous state Oct 31, 2024
@AlekseyManetov AlekseyManetov merged commit 1c990aa into develop Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants