Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataTable]: columns group. #2599

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

Kuznietsov
Copy link
Collaborator

@Kuznietsov Kuznietsov commented Nov 1, 2024

Summary

Added column groups to DataTable.

Issue: #2634

@Kuznietsov Kuznietsov self-assigned this Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Generated by: track-bundle-size
Generated at: Tue, 05 Nov 2024 09:24:05 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.10.0 (2024-10-15)
CI Status: ok

Module Baseline Size
(v5.10.0)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 760.53 770.27 +9.73
js:+4.09
css:+5.63
🆗 684.48 - 836.59
@epam/app 5578.86 5640.39 +61.53
js:+11.33
css:+50.2
🆗 5020.98 - 6136.75
@epam/draft-rte 53.77 53.77 +0.01
js:+0
css:+0
🆗 48.39 - 59.15
@epam/electric 4.57 4.59 +0.01
js:+0
css:+0.01
🆗 4.12 - 5.03
@epam/promo 57.15 57.43 +0.28
js:0
css:+0.28
🆗 51.44 - 62.87
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 93.74 94.06 +0.31
js:+0.01
css:+0.31
🆗 84.36 - 103.11
@epam/uui-components 263.21 267.62 +4.4
js:+4.3
css:+0.1
🆗 236.89 - 289.54
@epam/uui-core 337.45 338.17 +0.72
js:+0.72
css:0
🆗 303.7 - 371.19
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 207.12 207.12 0
js:0
css:0
🆗 186.41 - 227.83
@epam/uui-editor 183.61 183.71 +0.1
js:+0.08
css:+0.01
🆗 165.25 - 201.97
@epam/uui-timeline 79.51 80.98 +1.46
js:+1.47
css:0
🆗 71.56 - 87.46
@epam/uui 606.81 619.71 +12.9
js:+6.82
css:+6.08
🆗 546.13 - 667.49
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.11.0-rc.0",
  "timestamp": "2024-11-05",
  "sizes": {
    "templateApp": {
      "css": 305813,
      "js": 482935
    },
    "@epam/app": {
      "css": 730366,
      "js": 5045394
    },
    "@epam/draft-rte": {
      "css": 9773,
      "js": 45296
    },
    "@epam/electric": {
      "css": 2289,
      "js": 2409
    },
    "@epam/promo": {
      "css": 47916,
      "js": 10894
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 53755,
      "js": 42554
    },
    "@epam/uui-components": {
      "css": 22637,
      "js": 251401
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 346284
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2448,
      "js": 209640
    },
    "@epam/uui-editor": {
      "css": 12748,
      "js": 175370
    },
    "@epam/uui-timeline": {
      "css": 2254,
      "js": 80667
    },
    "@epam/uui": {
      "css": 284003,
      "js": 350580
    }
  }
}

Generated by: generate-components-api
CI Status: ok

Total amount of exported types/props without JSDoc comments

Amount
Types 300 (+0) 🆗
Props 233 (+0) 🆗

@@ -20,7 +20,7 @@
padding-inline-end: var(--uui-dt-header-cell-padding-end);
width: 0;
background-clip: padding-box;
height: var(--uui-dt-header-cell-height);
min-height: var(--uui-dt-header-cell-height);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required for DataTableHeaderCell to expand to 100% height if groups are enabled.

uui-core/src/hooks/useColumnGroups.ts Outdated Show resolved Hide resolved
uui-core/src/hooks/useColumnGroups.ts Outdated Show resolved Hide resolved
uui/components/tables/DataTable.tsx Outdated Show resolved Hide resolved
@Kuznietsov Kuznietsov changed the base branch from develop to feature/rc-version November 5, 2024 09:54
@Kuznietsov Kuznietsov merged commit 2234d37 into feature/rc-version Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants