Fix issue when analytics not being sent when href
prop used
#2612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed issue when
clickAnalyticsEvent
not being sent whenhref
prop used at components, that uses inner Clickable component:Tag
,Badge
,Anchor
,TabButton
,MainMenuButton
,Button
,LinkButton
,IconButton
.Issue link:
Closes #2611
QA notes:
Honestly, I don't like the idea to mock entire
React.useContext
, especially when it is required to mock more API than is actually to be tested. There's an option to mock justjest.spyOn(AnalyticsContext.prototype, 'sendEvent')
in updated test cases instead.