Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): add error messages for failed publish requests (Issue #1481) #1840

Merged
merged 13 commits into from
Aug 1, 2024

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Jul 29, 2024

Description:

Add receiving error messages through Next proxy api and displaying them in failed publish requests: approve, create and rulesList

Issues:

UI changes

Снимок экрана 2024-07-29 в 18 39 32 Снимок экрана 2024-07-29 в 18 40 00

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir
Copy link
Contributor Author

Gimir commented Jul 29, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: failed

apps/chat/src/utils/server/get-response-error-msg.ts Outdated Show resolved Hide resolved
apps/chat/src/utils/server/api.ts Show resolved Hide resolved
apps/chat/src/utils/server/api.ts Outdated Show resolved Hide resolved
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Jul 30, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Jul 31, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Jul 31, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: failed

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Aug 1, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Aug 1, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-1840.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir merged commit 066fc55 into development Aug 1, 2024
9 checks passed
@Gimir Gimir deleted the fix/1481-error-notifications branch August 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working _priority_2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants