fix(chat): increase max headers size (Issue #2852) #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Kezik
requested review from
Gimir,
denys-kolomiitsev,
IlyaBondar,
Derikyan and
likeamike
as code owners
denys-kolomiitsev
previously approved these changes
Dec 24, 2024
IlyaBondar
previously approved these changes
Dec 26, 2024
|
/deploy-review
|
IlyaBondar
reviewed
Dec 26, 2024
| @@ -131,6 +131,7 @@ AI DIAL Chat uses environment variables for configuration. All environment varia | |||
| | `SHOW_TOKEN_SUB` | No | Show token sub in refresh login error logs | `true`, `false` | `false` | | |||
| | `STORAGE_TYPE` | No | Type of storage used for getting and saving information generated by a user.<br />**Note**: currently, `api` is the only supported value. | `browserStorage`, `api` | `api` | | |||
| | `KEEP_ALIVE_TIMEOUT` | No | Determines the maximum time in milliseconds for an idle connection before it is closed by the server.<br />This is needed because infrastructures usually have a default keep alive timeout 60 seconds and the Next server should have a larger value.<br />**Note**: this variable is used only when running a `dockerfile`. | Any number string | `61000` | | |||
| | `MAX_HTTP_HEADERS_SIZE` | No | Defines the maximum size of headers for Next.js server. <br />**Note**: this variable is used only when running a `dockerfile`. | `32768` | | |||
There was a problem hiding this comment.
Need to check that for our environments (local, Review, Staging) also is used default limit with 32 KB
justrp
reviewed
Jan 4, 2025
…to fix/max-headers-size
Derikyan
dismissed stale reviews from IlyaBondar and denys-kolomiitsev
via
895df0a
|
/deploy-review
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
increase max headers size
Issues:
Checklist:
fix(<scope>):,feat(<scope>):,feature(<scope>):,chore(<scope>):,hotfix(<scope>):ore2e(<scope>):. If contains breaking changes then the pull request name must start withfix(<scope>)!:,feat(<scope>)!:,feature(<scope>)!:,chore(<scope>)!:,hotfix(<scope>)!:ore2e(<scope>)!:where<scope>is name of affected project:chat,chat-e2e,overlay,shared,sandbox-overlay, etc.(Issue #<TICKET_ID>)(comma-separated list of issues)