fix: Application/Model listing API returns wrong value for max_retry_…

…attemps #616
epam · Dec 13, 2024 · 5691e1b · 5691e1b
1 parent 6b01926
commit 5691e1b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/server/src/main/java/com/epam/aidial/core/server/controller/DeploymentController.java b/server/src/main/java/com/epam/aidial/core/server/controller/DeploymentController.java
@@ -22,6 +22,8 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import static com.epam.aidial.core.server.controller.ModelController.createModel;
+
 @RequiredArgsConstructor
 public class DeploymentController {
 
@@ -39,7 +41,7 @@ public Future<?> getDeployment(String deploymentId) {
             return context.respond(HttpStatus.FORBIDDEN);
         }
 
-        DeploymentData data = createDeployment(model);
+        DeploymentData data = createModel(model);
         return context.respond(HttpStatus.OK, data);
     }
 
@@ -49,7 +51,7 @@ public Future<?> getDeployments() {
 
         for (Model model : config.getModels().values()) {
             if (model.hasAccess(context.getUserRoles())) {
-                DeploymentData deployment = createDeployment(model);
+                DeploymentData deployment = createModel(model);
                 deployments.add(deployment);
             }
         }
@@ -95,13 +97,6 @@ public static Future<Deployment> selectDeployment(ProxyContext context, String i
         }, false);
     }
 
-    private static DeploymentData createDeployment(Model model) {
-        DeploymentData deployment = new DeploymentData();
-        deployment.setId(model.getName());
-        deployment.setModel(model.getName());
-        return deployment;
-    }
-
     static FeaturesData createFeatures(Features features) {
         FeaturesData data = new FeaturesData();
 

diff --git a/server/src/main/java/com/epam/aidial/core/server/controller/ModelController.java b/server/src/main/java/com/epam/aidial/core/server/controller/ModelController.java
@@ -55,7 +55,7 @@ public Future<?> getModels() {
         return context.respond(HttpStatus.OK, list);
     }
 
-    private static ModelData createModel(Model model) {
+    static ModelData createModel(Model model) {
         ModelData data = new ModelData();
         data.setId(model.getName());
         data.setModel(model.getName());
@@ -68,6 +68,7 @@ private static ModelData createModel(Model model) {
         data.setMaxInputAttachments(model.getMaxInputAttachments());
         data.setReference(model.getName());
         data.setDescriptionKeywords(model.getDescriptionKeywords());
+        data.setMaxRetryAttempts(model.getMaxRetryAttempts());
 
         if (model.getType() == ModelType.EMBEDDING) {
             data.getCapabilities().setEmbeddings(true);