feat: Implement user limits #82 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artsiomkorzun
previously approved these changes
Mar 13, 2024
artsiomkorzun
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3:27 PM] Aliaksandr Stsiapanay
Hi,
I want to propose changes based on the yesterday's discussion about user limits:
We can merge user into api-key limits to unify the config. In case of role name clashes we can resolve these issues manually in config.
As for default user limits there are 3 options how to read it:
2.1 Make a new field defaultUserLimits to the model settings.
2.2 Make a default user role in the section role and use it to read the default limits. Also we need to a new setting to dial settings something like defaultUserRole
2.3 Add default user role for all users in IDP and configure user limits for that role in DIAL config. (my preference)
Add support of request per minute/day limits in a separate issue. We can extend limit configuration for requests as well.
What do you think?
[3:33 PM] Aliaksei Vavilau
I think it could be enough if done right. I would take simplest approach for #2. Which I believe #2