Refactor Textarea autosize prop to handle when a single line takes up multiple rows #4061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
autosize
, the previous calculation for rows was based on finding new line characters "\n" in the textbox value. This meant the height didn't adjust when a single line wrapped around to a new line.This changes the computation to use lineHeight and scrollHeight to determine the number of visible rows for the textbox regardless of new line characters. It still respects
min-rows
andmax-rows
props when provided.Markup:
Types of changes