Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add area to echo mission #1244

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Add area to echo mission #1244

merged 6 commits into from
Dec 19, 2023

Conversation

oysand
Copy link
Contributor

@oysand oysand commented Dec 8, 2023

No description provided.

@oysand oysand force-pushed the add-area-to-echo-mission branch 2 times, most recently from 69597f1 to ab4f35c Compare December 8, 2023 14:15
@Eddasol Eddasol marked this pull request as draft December 12, 2023 15:10
@oysand oysand force-pushed the add-area-to-echo-mission branch 2 times, most recently from 87b25c5 to 1bdb4cf Compare December 14, 2023 10:12
@github-actions GitHub Actions
Copy link

🔔 Changes in database folder detected 🔔
Do these changes require adding new migrations? 🤔 In that case follow these steps.
If you are uncertain, ask a database admin on the team 😄

@oysand oysand force-pushed the add-area-to-echo-mission branch 6 times, most recently from d160bc7 to 440cbc6 Compare December 19, 2023 12:45
@oysand oysand marked this pull request as ready for review December 19, 2023 12:47
andchiind
andchiind reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright otherwise

backend/api.test/Mocks/EchoServiceMock.cs Outdated Show resolved Hide resolved
backend/api.test/Mocks/StidServiceMock.cs Show resolved Hide resolved
backend/api/Controllers/MissionSchedulingController.cs Outdated Show resolved Hide resolved
backend/api/Controllers/MissionSchedulingController.cs Outdated Show resolved Hide resolved
backend/api/Database/Context/InitDb.cs Outdated Show resolved Hide resolved
backend/api/Database/Context/InitDb.cs Outdated Show resolved Hide resolved
@oysand oysand force-pushed the add-area-to-echo-mission branch from 440cbc6 to d080228 Compare December 19, 2023 13:12
@oysand oysand requested a review from andchiind December 19, 2023 13:15
andchiind
andchiind approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oysand oysand merged commit c67dae4 into equinor:main Dec 19, 2023
9 checks passed
@oysand oysand deleted the add-area-to-echo-mission branch December 19, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oysand @andchiind