Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mission page #1848

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Improve mission page #1848

merged 1 commit into from
Jan 10, 2025

Conversation

mrica-equinor
Copy link
Contributor

No description provided.

@mrica-equinor mrica-equinor force-pushed the main branch 3 times, most recently from f14103a to acb193d Compare December 5, 2024 14:10
eivindsjovold
eivindsjovold requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-run snyk checks

@mrica-equinor mrica-equinor marked this pull request as draft December 19, 2024 14:50
@mrica-equinor mrica-equinor force-pushed the main branch 5 times, most recently from 7419460 to 3e73ddc Compare January 8, 2025 11:10
@mrica-equinor mrica-equinor marked this pull request as ready for review January 8, 2025 11:11
@eivindsjovold eivindsjovold self-requested a review January 8, 2025 12:08
eivindsjovold
eivindsjovold previously approved these changes Jan 8, 2025
View reviewed changes
eivindsjovold
eivindsjovold reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@eivindsjovold eivindsjovold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snyk ok

Eddasol
Eddasol reviewed Jan 8, 2025
View reviewed changes
frontend/src/components/Pages/MissionPage/MissionPage.tsx
const StyledMissionPageCardsWidth = styled.div`
display: flex;
flex-direction: column;
min-width: 50%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 50%? I would just remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what keeps the card with the status, area, etc with the same min-width as the card around the table, otherwise would be smaller than the card around the table (and map)

@eivindsjovold eivindsjovold dismissed their stale review January 8, 2025 12:40

did not mean to approve - only remove block

@mrica-equinor mrica-equinor force-pushed the main branch 3 times, most recently from 47cbbda to 39d245d Compare January 9, 2025 08:55
@mrica-equinor mrica-equinor requested a review from Eddasol January 9, 2025 08:55
andchiind
andchiind approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested it and did not find any bugs on desktop or phone.

@mrica-equinor mrica-equinor merged commit 753f438 into equinor:main Jan 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eivindsjovold eivindsjovold eivindsjovold left review comments

@andchiind andchiind andchiind approved these changes

@Eddasol Eddasol Awaiting requested review from Eddasol

Assignees

@mrica-equinor mrica-equinor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrica-equinor @andchiind @Eddasol @eivindsjovold