Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove suppressing of lint rules #1946

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove suppressing of lint rules #1946

merged 2 commits into from
Jan 17, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 14, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol
Copy link
Contributor Author

Eddasol commented Jan 15, 2025

Solves parts of #1908

@Eddasol Eddasol self-assigned this Jan 15, 2025
@Eddasol Eddasol added improvement Improvement to existing functionality frontend Frontend related functionality labels Jan 15, 2025
@Eddasol Eddasol force-pushed the lint-fix branch 2 times, most recently from 020c2e9 to 2080db8 Compare January 15, 2025 14:53
Christdej
Christdej approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 87eb838 into equinor:main Jan 17, 2025
12 checks passed
@Eddasol Eddasol deleted the lint-fix branch January 17, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@Eddasol Eddasol

Labels
frontend Frontend related functionality improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @Christdej