Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mission scheduling when battery is low #1961

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Allow mission scheduling when battery is low #1961

merged 2 commits into from
Jan 17, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 17, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@Eddasol Eddasol self-assigned this Jan 17, 2025
@Eddasol Eddasol linked an issue Jan 17, 2025 that may be closed by this pull request
Allow missions to be queued when battery/pressure is out of range #1775
Closed
@Eddasol Eddasol force-pushed the low-battery branch 2 times, most recently from 8535de2 to a3db66a Compare January 17, 2025 07:33
Christdej
Christdej approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol merged commit 3fee8e6 into equinor:main Jan 17, 2025
12 checks passed
@Eddasol Eddasol deleted the low-battery branch January 17, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees

@Eddasol Eddasol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow missions to be queued when battery/pressure is out of range
2 participants
@Eddasol @Christdej