Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change misleading 'timeseries' naming #1996

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Change misleading 'timeseries' naming #1996

merged 3 commits into from
Jan 30, 2025

Conversation

Eddasol
Copy link
Contributor

@Eddasol Eddasol commented Jan 30, 2025

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

Christdej
Christdej approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Christdej Christdej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eddasol Eddasol force-pushed the timeseries-cleanup branch from 89cb405 to 8a1ecd3 Compare January 30, 2025 13:11
@Eddasol Eddasol merged commit d26acac into equinor:main Jan 30, 2025
12 checks passed
@Eddasol Eddasol deleted the timeseries-cleanup branch January 30, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christdej Christdej Christdej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eddasol @Christdej