Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make an AnomalyDetectorBase ABC #393

Closed
milesgranger opened this issue Aug 9, 2019 · 0 comments · Fixed by #627
Closed

Make an AnomalyDetectorBase ABC #393

milesgranger opened this issue Aug 9, 2019 · 0 comments · Fixed by #627
Assignees
@milesgranger

Comments

@milesgranger
Copy link
Contributor

milesgranger commented Aug 9, 2019 •
edited
Loading

#368 abstracts the previous anomaly calculations into an DiffBasedAnomalyDetector which basically implements a .anomaly method.

To lay the foundation for implementing different types of anomaly detectors, we should create an ABC for such models.

Should update gordo_components/server/views/anomaly.py to check for isinstance rather than catching the AttributeError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milesgranger milesgranger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement an AnomalyDetectorBase ABC
1 participant
@milesgranger