Make autoencoders take a y #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 89.32% 89.49% +0.16%
==========================================
Files 48 52 +4
Lines 2211 2275 +64
==========================================
+ Hits 1975 2036 +61
- Misses 236 239 +3
Continue to review full report at Codecov.
|
epa095
reviewed
Jul 8, 2019
milesgranger
commented
Aug 1, 2019
milesgranger
commented
Aug 1, 2019
epa095
reviewed
Aug 6, 2019
milesgranger
changed the title
epa095
reviewed
Aug 7, 2019
milesgranger
commented
Aug 8, 2019
milesgranger
commented
Aug 8, 2019
This was referenced Aug 9, 2019
epa095
reviewed
Aug 9, 2019
epa095
reviewed
Aug 9, 2019
This was referenced Aug 12, 2019
epa095
reviewed
Aug 12, 2019
Previously, y was implicitly set as a copy of X. This seperates that logic such that anomaly calculations are done in a scikit-learn like model. Therefore additional changes to the server, client and other components in the codebase are in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #364
Will also close #371 (because it will no longer be relevant)
Allows an 'autoencoder' to take X
via a Pipeline for example, but then train itself to output
the same unscaled values to match y. Models will no longer implicitly train themselves for
X(which was often scaled via previous steps in the Pipeline) Therefore the Pipeline/preprocessing steps before the model are part of the encoding
process.
yinverse-transformed-model-outputdoesn't make sense anymore)PRs depending on this
PR depends on:
target_tag_listin workflow generation if not specified