Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start update #1170

Merged
merged 4 commits into from
Jan 27, 2025
Merged

start update #1170

merged 4 commits into from
Jan 27, 2025

Conversation

EvenSol
Copy link
Collaborator

@EvenSol EvenSol commented Nov 7, 2024

No description provided.

@EvenSol EvenSol linked an issue Nov 7, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 26.86567% with 49 lines in your changes missing coverage. Please review.

Project coverage is 38.61%. Comparing base (e3cfc3d) to head (d9d59cd).

Files with missing lines Patch % Lines
...neqsim/process/equipment/diffpressure/Orifice.java 26.86% 48 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1170      +/-   ##
============================================
- Coverage     38.62%   38.61%   -0.01%     
- Complexity     5790     5796       +6     
============================================
  Files           715      716       +1     
  Lines         70770    70837      +67     
  Branches       8130     8133       +3     
============================================
+ Hits          27335    27355      +20     
- Misses        41807    41853      +46     
- Partials       1628     1629       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvenSol EvenSol marked this pull request as ready for review January 27, 2025 23:16
@EvenSol EvenSol merged commit 02d8e8b into master Jan 27, 2025
9 checks passed
@EvenSol EvenSol deleted the 1169-add-orifice-modelling branch January 27, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add orifice modelling
2 participants