Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more robust setting of beta #1253

Merged
merged 3 commits into from
Jan 11, 2025
Merged

Conversation

asmfstatoil
Copy link
Collaborator

using neqsim.thermo.ThermodynamicModelSettings.phaseFractionMinimumLimit

@asmfstatoil asmfstatoil requested a review from EvenSol as a code owner January 11, 2025 08:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.61972% with 45 lines in your changes missing coverage. Please review.

Project coverage is 41.13%. Comparing base (0cf54fb) to head (deb6b27).

Files with missing lines Patch % Lines
...thermodynamicoperations/flashops/RachfordRice.java 33.33% 14 Missing and 2 partials ⚠️
.../thermodynamicoperations/flashops/SolidFlash1.java 0.00% 12 Missing ⚠️
...m/thermodynamicoperations/flashops/SolidFlash.java 0.00% 6 Missing ⚠️
...qsim/thermodynamicoperations/flashops/TPflash.java 62.50% 4 Missing and 2 partials ⚠️
...c/main/java/neqsim/thermo/system/SystemThermo.java 50.00% 2 Missing and 1 partial ⚠️
src/main/java/neqsim/thermo/phase/Phase.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1253      +/-   ##
============================================
- Coverage     41.15%   41.13%   -0.02%     
+ Complexity     6032     6030       -2     
============================================
  Files           722      722              
  Lines         68331    68334       +3     
  Branches       8160     8162       +2     
============================================
- Hits          28120    28112       -8     
- Misses        38532    38541       +9     
- Partials       1679     1681       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good update👍

@asmfstatoil asmfstatoil merged commit 0fe37d1 into equinor:master Jan 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants