Prohibition for using 6.0 types in register and context extension vars #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
reviewed
Jan 20, 2025
| case c: Constant[_] => v6TypeCheck(c.tpe) | ||
| case c: EvaluatedCollection[_, _] => v6TypeCheck(c.elementType) | ||
| case GroupGenerator => | ||
| } |
There was a problem hiding this comment.
What is the motivation to add and check this rule?
There was a problem hiding this comment.
The problem is that deserialization of values in registers and context extension is not versioned, so newly supported serializable types (Header, Option[], UnsignedBigInt) can't be put there (but serialized as Coll[Byte] value can be put there to be used with Global.deserialize )
SethDusek
reviewed
Jan 22, 2025
| } | ||
| } | ||
| v match { | ||
| case c: Constant[_] => v6TypeCheck(c.tpe) |
There was a problem hiding this comment.
It seems it is possible to serialize/parse Tuple with v6 type
property("impossible to use v6 types in box registers") {
val trueProp = ErgoTreePredef.TrueProp(ErgoTree.defaultHeaderWithVersion(3))
val b = new ErgoBoxCandidate(1L, trueProp, 1,
additionalRegisters = Map(R4 -> Tuple(UnsignedBigIntConstant(new BigInteger("1")), IntConstant(1))))
VersionContext.withVersions(3, 3) {
val bs = ErgoBoxCandidate.serializer.toBytes(b)
a[sigma.validation.ValidationException] should be thrownBy ErgoBoxCandidate.serializer.fromBytes(bs)
}
}doesn't throw exception
There was a problem hiding this comment.
@SethDusek fixed, the reason was c.elementType being SAny for Tuple. Made test for UBI as second tuple element, and collection as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.