Fix/subgrid oro param #1291
Closed
Fix/subgrid oro param #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandresm
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Thanks @ackerlar for this PR. The only problem I see is that the tests fail because you made dEBM a submodule of ESM-Tools and it cannot clone it. I can fix that, by simply telling git not to update that submodule on the tests, or adding a secret to github actions to get access to that repository.
However, I am wondering if it makes sense to have it added as a submodule when all the other models are managed by esm_master. What do you both @pgierz and @ackerlar think about this topic?
|
Ah, this was not intended! I fix it after our group meeting |
|
Hopefully fixed here #1293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some updates to the orography update in the awiesm-pism coupling