New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #2589 - i2Csetup for ESP 32-C3 #2600

Open

SimonGAndrews wants to merge 5 commits into espruino:master from SimonGAndrews:master

SimonGAndrews commented Jan 19, 2025

See comments in the issue #2589 regarding the details of the change and the testing completed.
Note

the ESP32-S3 build was not tested but hopefully and should be ok.
the element of this change, which reverses default pins for SDA & SCL for the ESP32 build (as discussed in the issue) will be a breaking change for anyone depending upon the I2C1.setup() function without specifying SDA and SCL in a config for the an ESP32 setup. However the ESP32 build will now be inline with common documentation.

SimonGAndrews and others added 5 commits

January 6, 2025 21:33


          I2C Setup changes for testing against issue espruino#2589

22f6053


          I2c Changes for testing Round2 against espruino#2589

23b697f


          Update build.yml form RELEASE=1 to DEBUG=1 for ESP32 builds

8c526a0


          Merge branch 'espruino:master' into master

14119c7


          Fixes for espruino#2589 I2C1 and I2C2 pin defaults in ESP32.py and Re…

f50ed22

…vert Debug =1 for build action workflow testing,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet