feat: inject console_error_panic_hook into constructors of Workbook and Worksheet #38
+96
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaroning
reviewed
Jan 10, 2025
| @@ -34,6 +34,7 @@ impl Workbook { | |||
| /// TODO: example omitted | |||
| #[wasm_bindgen(constructor)] | |||
| pub fn new() -> Self { | |||
| console_error_panic_hook::set_once(); | |||
There was a problem hiding this comment.
How do you think of calling std::panic_set_hook in the default export (xlsxInit) instead?
std::panic::set_hook(Box::new(console_error_panic_hook::hook));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show detailed error messages in the browser's console view,
console_error_panic_hookis injected into the constructors ofWorkbookandWorksheet. Additionally, a redundant function has been removed.