Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wzshiming as a reviewer #55

Closed
wants to merge 1 commit into from

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 11, 2024

I am a maintainer of KWOK, which simulates a k8s cluster. in many cases, direct manipulation of etcd would be helpful to simulate edge cases.

I would like to help improve this repo.

#3

Signed-off-by: Shiming Zhang <[email protected]>
@wzshiming wzshiming force-pushed the reviewer-wzshiming branch from 1cf2888 to 8110dc7 Compare May 11, 2024 07:14
@k8s-ci-robot
Copy link

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the etcd-io org. You can then trigger verification by writing /verify-owners in a comment.

  • wzshiming
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@wzshiming
Copy link
Member Author

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wzshiming - Thanks for volunteering and for your contributions so far to auger!: https://github.com/search?q=org%3Aetcd-io+author%3Awzshiming+is%3Amerged&type=pullrequests

The first step for becoming a Reviewer is to become an etcd-io project Member, please refer to: https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/community-membership.md

I am happy to sponsor you to become a Member. Once you have a second sponsor please open a membership nomination issue against the kubernetes/org repo 🙏🏻

I will close this pr as you need to first become and org Member and contribute to the project further as a Member before Reviewer role would be granted.

@jmhbnz jmhbnz closed this May 11, 2024
@wzshiming
Copy link
Member Author

wzshiming commented May 11, 2024

Thank you, I found out that etcd-io and kubernetes memberships are equivalent. 😄

kubernetes/org#4945

The org memberships are now equivalent and sponsorship is not needed to join additional Kubernetes GitHub orgs.

@wzshiming
Copy link
Member Author

/reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants