Add robustness failpoint for IO stall in raft loop #16859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhouJianMS <[email protected]>
ZhouJianMS
force-pushed
the
zhoujian/raft-io-stall
branch
from
f31c859 to
827dc18
Compare
serathius
reviewed
Nov 3, 2023
serathius
reviewed
Nov 3, 2023
|
@ZhouJianMS Thanks for contribution! I have been looking into adding sleep during robustness for some time. #16776 Main blocker was etcd-io/gofail#47. Addition of API that would allow us to confirm that sleep was really executed. I really like the idea of deactivating the failpoint, it should allow us to longer sleep times without breaking the minimal qps requirement. |
serathius
previously approved these changes
Nov 3, 2023
serathius
reviewed
Nov 3, 2023
serathius
reviewed
Nov 3, 2023
serathius
reviewed
Nov 3, 2023
serathius
dismissed
their stale review
Ups, missed couple of error handling issues.
Signed-off-by: ZhouJianMS <[email protected]>
|
@serathius Error handling added, please review. |
serathius
approved these changes
Nov 3, 2023
|
Looks like the failpoint worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new failpoint to simulate an IO stall in the Raft loop during robustness tests. Extensible to check whether the stalled raft loop handled properly once #15247 (comment) or similar fix merged.