Unit Test Multisig Task Contract

[ElliotFriedman]

Unit Test Multisig Contract

Add the most unit test like contracts we can for the MultisigTask file

Tests

These tests look for calldata length, targets and values to make sure they all line up.

Metadata

#480

[blmalone]

Same question as I asked in discord, is this test adding anymore value that #485 isn't already adding?

[ElliotFriedman]

Same question as I asked in discord, is this test adding anymore value that #485 isn't already adding?

I wanted to make this a unit test version of #485 but it became clear that the following things would need to be true for the unit test to work without being on mainnet:

1. we have an actual deployed safe we are talking to
2. we set the ChainId to either mainnet or sepolia so that the AddressRegistry contract will work. if we have a local chainid 31337, then it does not work as the constructor of AddressRegistry will revert
3. then we'd need a mock contract to call and do some action

[prateek105]

Same question as I asked in discord, is this test adding anymore value that #485 isn't already adding?

I think the value that these tests are adding is that these are covering more untested branches in the MultisigTask contract. @ElliotFriedman can confirm. @blmalone

[prateek105]

lgtm

[blmalone]

This is my first pass. I still have to finish going through all the files.

[blmalone]

It's looking great. I've completed my final pass. I approved on the basis the comments are addressed here.