Generate artifacts for all contracts of an ingot #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/all_contract_artifacts
branch
from
0c3c7b4 to
f62d788
Compare
|
I rambled more about this in #725. I believe this is a better default. |
sbillig
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Currently, when compiling an ingot with a
main.fe, artifacts are only generated for the contracts that are defined withinmain.fe. We should generate artifacts for all contracts of the ingot instead.How was it fixed?
Adjusted the
module.all_contracts(..)API to include contracts of submodules.