fix(web): audit trace graph left align #354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the old approach, the floating point conversion made it pointless to use BigNum at all anyway. This should be faster and more precise. The only rounding that happens is at the sub-pixel level. Also, removes an unused variable.
Node IDs near 0 were drifting off the left side of the screen. I wish I knew why this padding was necessary. I don't have much confidence that it will work at all resolutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: When sorted by Node ID, the IDs closest to 0 would be rendered off-screen to the left.
Most of this is a refactor. The only thing that made any difference was adding a padding-left. I don't love the solution, but I couldn't find why the left of the svg was shifted left off the viewport in the first place. So this was all I could come up with. Open to suggestions!