core/{state, vm}: update stateless gas costs to follow the verkle-gen-7 testnet #31014
+284
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
force-pushed
the
kaustinen7-gas-costs
branch
2 times, most recently
from
9f3ab25 to
c92a0d4
Compare
| // list in write mode. If there is enough gas paying for the addition of the code | ||
| // hash leaf to the access list, then account creation will proceed unimpaired. | ||
| // Thus, only pay for the creation of the code hash leaf here. | ||
| wgas := evm.AccessEvents.CodeHashGas(addr, true, gas, false) |
There was a problem hiding this comment.
If the available gas is not sufficient to pay the cost, availableGas will be returned.
Originally, the evm execution should stop without executing this operation;
Now, the evm execution will execute this operation, and may stop later;
There was a problem hiding this comment.
already responded during standup - good idea but that's a spec change so we should try to fix it over time but this is what the testnet does.
… testnet Co-authored-by: Ignacio Hagopian <[email protected]> Signed-off-by: Guillaume Ballet <[email protected]>
Signed-off-by: Guillaume Ballet <[email protected]>
gballet
force-pushed
the
kaustinen7-gas-costs
branch
from
1ceb3e2 to
e7dd2e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding values to the witness introduces a new class of issues for computing gas: if there is not enough gas to cover adding an item to the witness, then the item should not be added to the witness.
The problem happens when several items are added together, and that process runs out of gas. The witness gas computation needs a way to signal that not enough gas was provided. These values can not be hardcoded, however, as they are context dependent, i.e. two calls to the same function with the same parameters can give two different results.
The approach is to return both the gas that was actually consumed, and the gas that was necessary. If the values don't match, then a witness update OOG'd. The caller should then charge the
consumedvalue (remaining gas will be 0) and error out.Why not return a boolean instead of the wanted value? Because when several items are touched, we want to distinguish which item lacked gas.