Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Maintenance Release Round #2648

Merged
merged 18 commits into from
Apr 24, 2023
Merged

New Maintenance Release Round #2648

merged 18 commits into from
Apr 24, 2023

Conversation

holgerd77
Copy link
Member

@holgerd77 holgerd77 commented Apr 18, 2023

Releases on all libraries except RLP, various bug fixes and other maintenance updates (performance, dependencies), also some spec updates on EIP-4844.

Follow-up on #2556, #2549 and #2521.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2648 (8417756) into master (ca32296) will increase coverage by 0.64%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.18% <ø> (ø)
blockchain 90.40% <ø> (ø)
client 87.12% <ø> (-0.02%) ⬇️
common 95.74% <ø> (ø)
devp2p 91.97% <ø> (?)
ethash ∅ <ø> (∅)
evm 79.39% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 89.61% <ø> (ø)
trie 90.23% <ø> (?)
tx 94.43% <ø> (ø)
util 85.19% <ø> (ø)
vm 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
(modification: no type change headlines) and this project adheres to
[Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 8.0.6 - 2023-04-20

- Bump `@chainsafe/ssz` dependency to 0.11.0 (no WASM, native SHA-256 implementation, ES2019 compatible), PRs [#2622](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2622) and PR [#2564](https://github.com/ethereumjs/ethereumjs-monorepo/pull/2564)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be curious to ask some folks who complained about the WASM dependency if this does indeed resolve their issue (switching to noble-curves still appears to install as-sha256 - at least for us since I had to manually patch that in the karma test runner config)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a PR that seems to fix this here: ChainSafe/ssz#318 - pending review

acolytec3
acolytec3 previously approved these changes Apr 19, 2023
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

g11tech
g11tech previously approved these changes Apr 20, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@holgerd77
Copy link
Member Author

Note: this will get paused to see if there is a chance to get ChainSafe/ssz#313 (comment) settled before.

Please do not merge in between.

@FrederikBolding
Copy link
Contributor

FrederikBolding commented Apr 21, 2023

@holgerd77 This should be enough! #2656

@g11tech
Copy link
Contributor

g11tech commented Apr 21, 2023

@holgerd77 This should be enough! #2656

merged the PR! 🥳 we should be gtg with releases now

@holgerd77
Copy link
Member Author

Ok, great work 🎉, have updated this PR with the latest changes, ready for re-review!

@holgerd77
Copy link
Member Author

Ok, thanks for the reviews, will directly start with the releases as first task tomorrow morning.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@holgerd77 holgerd77 merged commit 49c2d93 into master Apr 24, 2023
@holgerd77 holgerd77 deleted the new-releases branch April 24, 2023 07:35
@holgerd77
Copy link
Member Author

Just published the following releases on npm:

acolytec3 pushed a commit that referenced this pull request May 12, 2023
* Draft various release notes

* CHANGELOG updates

* Version bump, updated upstream dependency versions, @ethereumjs/util v8.0.6

* Version bump, updated upstream dependency versions, @ethereumjs/common v3.1.2

* Version bump, updated upstream dependency versions, @ethereumjs/tx v4.1.2

* Version bump, updated upstream dependency versions, @ethereumjs/trie v5.0.5

* Add additional @chainsafe/ssz notes to CHANGELOG files of other libraries

* Version bump, updated upstream dependency versions, updated (all) client @ethereumjs dependencies, @ethereumjs/devp2p v5.1.2

* Version bump, updated upstream dependency versions, @ethereumjs/statemanager v1.0.5

* Version bump, updated upstream dependency versions, @ethereumjs/block v4.2.2

* Version bump, updated upstream dependency versions, @ethereumjs/ethash v2.0.5

* Version bump, updated upstream dependency versions, @ethereumjs/blockchain v6.2.2

* Version bump, updated upstream dependency versions, @ethereumjs/evm v1.3.2

* Version bump, updated upstream dependency versions, @ethereumjs/vm v6.4.2

* Version bump, @ethereumjs/client v0.7.1

* Rebuild package-lock.json

* Rebuild relevant documentation

* Updated @chainsafe/ssz related CHANGELOG entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants