Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch PERCENTAGE_MULTIPLIER from 2**24 to 10**6 to improve readability #77

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

switch PERCENTAGE_MULTIPLIER from 2**24 to 10**6 to improve readability #77

wants to merge 1 commit into from

Conversation

matthiaszimmermann
Copy link
Contributor

No description provided.

doerfli
doerfli approved these changes Oct 3, 2022 •
edited
Loading
View reviewed changes
doerfli
doerfli approved these changes Oct 3, 2022
View reviewed changes
contracts/examples/AyiiProduct.sol
@@ -27,7 +27,7 @@ contract AyiiProduct is

bytes32 public constant INSURER_ROLE = keccak256("INSURER");

uint256 public constant PERCENTAGE_MULTIPLIER = 2**24;
uint256 public constant PERCENTAGE_MULTIPLIER = 10**6;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? This will have impact on all contracts stored on the blockchain as they now contain wrong values, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you're correct this is a breaking change. unless we would migrate the existing data.
probably bad idea to do this during a season

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be handled by defining that we do not merge develop into mine while the season is running
needs to be properly discussed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss it when you're back.

@doerfli doerfli assigned doerfli and matthiaszimmermann and unassigned doerfli Oct 6, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doerfli doerfli doerfli approved these changes

Assignees

@doerfli doerfli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthiaszimmermann @CLAassistant @doerfli