Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize instance contracts #301

Closed
wants to merge 13 commits into from
Closed

Reorganize instance contracts #301

wants to merge 13 commits into from

Conversation

rapidddenis
Copy link
Collaborator

@rapidddenis rapidddenis commented Mar 22, 2024 •
edited
Loading

  • moves kv store write operations into InstanceStore
  • moves premium calculations into PricingService
  • moves instance initial authorizations configuration into InstanceAuthorizationsLibs

@rapidddenis
Copy link
Collaborator Author

previous pr was accidentally merged

@rapidddenis rapidddenis mentioned this pull request Mar 23, 2024
Closed
@rapidddenis rapidddenis added this to the GIF v3 Audit Ready milestone Mar 28, 2024
@mergify mergify bot mentioned this pull request Mar 28, 2024
Closed
@doerfli
Copy link
Contributor

doerfli commented Apr 2, 2024

i assume the diagrams

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Todo Commenter

contracts/instance/service/ApplicationService.sol
TODO:
  • add validations (see create bundle in pool service) Line: 99
  • add logging Line: 145
contracts/instance/service/BundleService.sol
TODO:
contracts/instance/service/DistributionService.sol
TODO:
  • zero should return false Line: 320
contracts/instance/service/PolicyService.sol
TODO:
  • add logging Line: 171
  • add logging Line: 207
  • add logging Line: 226
  • add logging Line: 577

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis mentioned this pull request Apr 7, 2024
Merged
@rapidddenis
Copy link
Collaborator Author

closing because of error, see #317

@rapidddenis rapidddenis closed this Apr 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
@doerfli doerfli deleted the reorganize-instance-contract branch June 27, 2024 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@doerfli doerfli doerfli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GIF v3 Audit Ready
Development

Successfully merging this pull request may close these issues.
2 participants
@rapidddenis @doerfli