Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize instance contract 2 #317

Merged
merged 5 commits into from
Apr 7, 2024
Merged

Reorganize instance contract 2 #317

merged 5 commits into from
Apr 7, 2024

Conversation

rapidddenis
Copy link
Collaborator

copy of #301

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Todo Commenter

contracts/instance/service/ApplicationService.sol
TODO:
  • add validations (see create bundle in pool service) Line: 99
  • add logging Line: 145
contracts/instance/service/BundleService.sol
TODO:
contracts/instance/service/DistributionService.sol
TODO:
  • zero should return false Line: 320
contracts/instance/service/PolicyService.sol
TODO:
  • add logging Line: 169
  • add logging Line: 205
  • add logging Line: 224
  • add logging Line: 575

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis mentioned this pull request Apr 7, 2024
Closed
@rapidddenis rapidddenis added this to the GIF v3 Audit Ready milestone Apr 7, 2024
@rapidddenis rapidddenis self-assigned this Apr 7, 2024
@rapidddenis rapidddenis merged commit d30275e into develop Apr 7, 2024
10 of 11 checks passed
@rapidddenis rapidddenis deleted the reorganize-instance-contract-2 branch April 7, 2024 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
@rapidddenis rapidddenis restored the reorganize-instance-contract-2 branch April 10, 2024 16:08
@rapidddenis rapidddenis deleted the reorganize-instance-contract-2 branch April 10, 2024 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rapidddenis rapidddenis

Labels
None yet
Projects
None yet
Milestone
GIF v3 Audit Ready
Development

Successfully merging this pull request may close these issues.
1 participant
@rapidddenis