Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorganize instance contracts #299

Merged
merged 9 commits into from
Mar 22, 2024
Merged

reorganize instance contracts #299

merged 9 commits into from
Mar 22, 2024

Conversation

rapidddenis
Copy link
Collaborator

@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/instance/service/ApplicationService.sol
TODO:
  • add validations (see create bundle in pool service) Line: 95
  • add logging Line: 141
  • maybe move this to a pricing service later Line: 180
contracts/instance/service/BundleService.sol
TODO:
contracts/instance/service/DistributionService.sol
TODO:
  • zero should return false Line: 392
contracts/instance/service/PolicyService.sol
TODO:
  • add logging Line: 179
  • add logging Line: 215
  • add logging Line: 234
  • move pool related tokens too Line: 355
  • move bundle related tokens too Line: 356
  • add logging Line: 360

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis merged commit e9a637d into develop Mar 22, 2024
10 of 11 checks passed
@rapidddenis rapidddenis deleted the reorganize-instance-contract branch March 22, 2024 16:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@rapidddenis rapidddenis restored the reorganize-instance-contract branch March 22, 2024 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthiaszimmermann matthiaszimmermann Awaiting requested review from matthiaszimmermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rapidddenis