Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Reorganize instance contract 2" #318

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Revert "Reorganize instance contract 2" #318

merged 2 commits into from
Apr 8, 2024

Conversation

rapidddenis
Copy link
Collaborator

Reverts #317

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Todo Commenter

contracts/instance/service/ApplicationService.sol
TODO:
  • maybe move this to a pricing service later Line: 180
contracts/instance/service/BundleService.sol
TODO:
contracts/instance/service/DistributionService.sol
TODO:
  • zero should return false Line: 386
contracts/instance/service/PolicyService.sol
TODO:
  • add logging Line: 164
  • add logging Line: 200
  • add logging Line: 219
  • add logging Line: 568

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis merged commit 27b4c35 into develop Apr 8, 2024
11 checks passed
@rapidddenis rapidddenis deleted the revert-317-reorganize-instance-contract-2 branch April 8, 2024 02:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rapidddenis