Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize instance contract 3 #325

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Reorganize instance contract 3 #325

merged 10 commits into from
Apr 10, 2024

Conversation

rapidddenis
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Todo Commenter

contracts/instance/service/ApplicationService.sol
TODO:
  • add validations (see create bundle in pool service) Line: 99
  • add logging Line: 146
contracts/instance/service/DistributionService.sol
TODO:
  • zero should return false Line: 326
contracts/instance/service/PolicyService.sol
TODO:
  • add logging Line: 168
  • add logging Line: 217
  • add logging Line: 236
  • add logging Line: 374

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis added this to the GIF v3 Audit Ready milestone Apr 10, 2024
@rapidddenis rapidddenis self-assigned this Apr 10, 2024
@rapidddenis rapidddenis merged commit b44ae3c into develop Apr 10, 2024
11 checks passed
@rapidddenis rapidddenis deleted the reorganize-instance-contract-5 branch April 10, 2024 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rapidddenis rapidddenis

Labels
instance
Projects
None yet
Milestone
GIF v3 Audit Ready
Development

Successfully merging this pull request may close these issues.
1 participant
@rapidddenis