Skip to content

Commit

Permalink
Merge pull request #68 from ethyca/rk-resources
Browse files Browse the repository at this point in the history
Allow for Fides-specific and Privacy-Center-specific Resources
  • Loading branch information
RobertKeyser authored Aug 28, 2023
2 parents b249f46 + 651f3ed commit f821ab8
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 18 deletions.
6 changes: 5 additions & 1 deletion fides/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ The types of changes are:
- `Fixed` for any bug fixes.
- `Security` in case of vulnerabilities.

## [Unreleased](https://github.com/ethyca/fides-helm/compare/fides-0.13.2...main)
## [Unreleased](https://github.com/ethyca/fides-helm/compare/fides-0.14.0...main)

### Added

Expand All @@ -26,6 +26,10 @@ The types of changes are:

### Changed

## [0.14.0](https://github.com/ethyca/fides-helm/compare/fides-0.13.8...fides-0.14.0)

### Changed
- **Breaking** Resources now specified at the fides and privacyCenter level. [#68](https://github.com/ethyca/fides-helm/pull/68)

## [0.13.8](https://github.com/ethyca/fides-helm/compare/fides-0.13.7...fides-0.13.8)

Expand Down
2 changes: 1 addition & 1 deletion fides/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: fides
version: 0.13.8
version: 0.14.0
appVersion: "2.18.0"
description: Fides is an open-source privacy engineering platform for managing the fulfillment of data privacy requests in your runtime environment, and the enforcement of privacy regulations in your code.
type: application
Expand Down
2 changes: 1 addition & 1 deletion fides/templates/fides/fides-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ spec:
- name: {{ $volume }}
mountPath: {{ $configPath }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.fides.resources | nindent 12 }}
volumes:
- name: {{ $volume }}
configMap:
Expand Down
2 changes: 1 addition & 1 deletion fides/templates/fides/worker-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
- name: {{ $volume }}
mountPath: {{ $configPath }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.fides.resources | nindent 12 }}
volumes:
- name: {{ $volume }}
configMap:
Expand Down
2 changes: 1 addition & 1 deletion fides/templates/privacy-center/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ spec:
- name: {{ $volume }}
mountPath: /app/config
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- toYaml .Values.privacyCenter.resources | nindent 12 }}
volumes:
- name: {{ $volume }}
configMap:
Expand Down
31 changes: 18 additions & 13 deletions fides/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ fides:
# fides.workers.count determines how many workers the deployment will use to process DSRs.
# To disable workers, set count to 0. This should be set to at least 1 in production environments.
count: 0
resources: {}
# If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 2048Mi
# requests:
# cpu: 100m
# memory: 2048Mi

# privacyCenter is the end-user facing application where data subjects can submit privacy requests.
privacyCenter:
Expand Down Expand Up @@ -86,6 +95,15 @@ privacyCenter:
service:
type: NodePort
port: 3000
resources: {}
# If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 1024Mi
# requests:
# cpu: 100m
# memory: 1024Mi

postgresql:
# postgresql.deployPostgres configures whether to install and configure the Bitnami Postgresql Helm chart
Expand Down Expand Up @@ -152,19 +170,6 @@ ingress:
# hosts:
# - privacy.example.com

resources:
{}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi

nodeSelector: {}

tolerations: []
Expand Down

0 comments on commit f821ab8

Please sign in to comment.