Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): setup continuous integration #11

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

zhishengtrieu
Copy link
Member

No description provided.

@alexvegas22
Copy link
Contributor

Est-ce qu'il est nécessaire de tester sur 2 versions de Node?

@JulienGiguere JulienGiguere self-requested a review October 3, 2024 23:15
Copy link
Collaborator

@JulienGiguere JulienGiguere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@alexvegas22 alexvegas22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bon pipeline, à voir s'il est nécessaire de compiler sous 2 versions, mais ça marche alors je l'approuve

@zhishengtrieu
Copy link
Member Author

il arrive que certains utilisent les versions LTS de v17/18/20 et d'autres les dernières versions, ca fait pas de mal de savoir si ça bien pour plusieurs versions (à limiter pour éviter un surcout bien sûr)

@zhishengtrieu zhishengtrieu merged commit 661f163 into main Oct 4, 2024
2 checks passed
@zhishengtrieu zhishengtrieu deleted the zhisheng-dev/chore/setup-infra branch October 4, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants