This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Remove shared dicts #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some errors were being introduced by the dictionary proxy objects, so instead of using shared dictionaries we now have a couple of queues that we populate in the subprocesses and then make the dictionaries in the main thread.
| self.exceptions = Manager().dict() | ||
| self.anomaly_breakdown = Manager().dict() | ||
| self.exceptions = dict() | ||
| self.anomaly_breakdown = dict() |
There was a problem hiding this comment.
If these are only accessed during the run() method, might it better to remove them as class properties and treat them as local variables only (in the run() method)?
| exceptions = dict() | ||
| anomaly_breakdown = dict() | ||
| while 1: | ||
| try: |
There was a problem hiding this comment.
Can we please do 4 spaces indentation as per PEP8?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #32
Removed the shared dictionaries that the analyzer process/subprocesses used to pass information and replaced them with queues instead.