This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
SKIPT_LIST is now a regex finder instead of having to especify the exact metric name #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
This adds a regex to the in_skip_list check so it will work with partial names for metric names.
This is a lifesaver in cases where you are generating the metrics automatically from an undetermined number of machines which can grow at any given moment.
I'll just explain our case, we have some ganglia metrics in our platform so I made a script that extracts them and sends them to horizon. The metric name is automatically generated from the platform_name.machine_name.metric_origin.metric_name and this machines can come up at any moment or go down at any moment so its not feasible to set the skip_list to anything as the platform name can change, and the machine name as well.
So in order to ignore metrics like whatever.whatever.hdd.BytesRead this regex will match either the origin (so we will use '.hdd.' to ignore all hdd metrics) or just the BytesRead metric ('.BytesRead').
Also, the old metrics will still match (so 'platform1.mysql.sda1.BytesRead' will only match that metric)