Skip to content

Commit

Permalink
don't unload replaydata for new scores during upload, need to write it
Browse files Browse the repository at this point in the history
  • Loading branch information
MinaciousGrace committed Apr 21, 2020
1 parent 799c10d commit 1edcc6c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/Etterna/Singletons/DownloadManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -929,9 +929,8 @@ DownloadManager::UploadScore(HighScore* hs,
return;
}

if (load_from_disk) {
if (load_from_disk)
hs->LoadReplayData();
}

CURL* curlHandle = initCURLHandle(true);
string url = serverURL.Get() + "/score";
Expand Down Expand Up @@ -970,7 +969,8 @@ DownloadManager::UploadScore(HighScore* hs,
replayString =
replayString.substr(0, replayString.size() - 1); // remove ","
replayString += "]";
hs->UnloadReplayData();
if(load_from_disk)
hs->UnloadReplayData();
} else {
// this should never be true unless we are using the manual forceupload
// functions
Expand Down Expand Up @@ -1100,7 +1100,7 @@ void
DownloadManager::UploadScoreWithReplayData(HighScore* hs)
{
this->UploadScore(
hs, []() {}, true /* (Without replay data loading from disk)*/);
hs, []() {}, false /* (Without replay data loading from disk)*/);
}

// for older scores or newer scores that failed to upload using the above
Expand Down

0 comments on commit 1edcc6c

Please sign in to comment.