Skip to content

Commit

Permalink
prevent entering player options when starting replays
Browse files Browse the repository at this point in the history
this does not break anything but also is an odd break in the order of execution if you think about it
  • Loading branch information
poco0317 committed Jul 12, 2021
1 parent 0245024 commit 2f64656
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/Etterna/Screen/Others/ScreenSelectMusic.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,7 @@ ScreenSelectMusic::Input(const InputEventPlus& input)
// reset announcer timer
m_timerIdleComment.GetDeltaTime();

// debugging?
// I just like being able to see untransliterated titles occasionally.
// toggle transliteration
if (input.DeviceI.device == DEVICE_KEYBOARD &&
input.DeviceI.button == KEY_F9) {
if (input.type != IET_FIRST_PRESS)
Expand All @@ -445,6 +444,14 @@ ScreenSelectMusic::Input(const InputEventPlus& input)
return true;
}

// dont allow touching anything on the transition into view eval/replays
// the only time this would not be null is if replay is being started
// it is nulled at the start of this screen
// if input breaks, this is why (it shouldnt break)
if (PlayerAI::pScoreData != nullptr) {
return false;
}

if (!IsTransitioning() && m_SelectionState != SelectionState_Finalized) {
auto bHoldingCtrl =
INPUTFILTER->IsBeingPressed(
Expand Down

0 comments on commit 2f64656

Please sign in to comment.